From e3f4dd42f626e6bf8b684eb3d157f66b60751eb4 Mon Sep 17 00:00:00 2001 From: Jacek Konieczny Date: Wed, 14 Nov 2012 10:24:28 +0000 Subject: [PATCH] hotplug/Linux: Fix locking in tools/hotplug/Linux/locking.sh The claim_lock() function would fail in the perl code with: Invalid argument at -e line 2. because the Perl snippet opens for reading the file descriptor, which was earlier opened for write (append). Signed-off-by: Jacek Konieczny Acked-by: Ian Jackson Acked-by: Ian Campbell Committed-by: Ian Campbell --- tools/hotplug/Linux/locking.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/hotplug/Linux/locking.sh b/tools/hotplug/Linux/locking.sh index e34f155438..122bcfb53b 100644 --- a/tools/hotplug/Linux/locking.sh +++ b/tools/hotplug/Linux/locking.sh @@ -44,7 +44,7 @@ claim_lock() # See below for a correctness proof. local rightfile while true; do - eval "exec $_lockfd>>$_lockfile" + eval "exec $_lockfd<>$_lockfile" flock -x $_lockfd || return $? # We can't just stat /dev/stdin or /proc/self/fd/$_lockfd or # use bash's test -ef because those all go through what is -- 2.30.2